Ban non-ambient namespaces written with `module` keyword #61450

RyanCavanaugh · 2025-03-19T20:29:40Z

Draft PR to assess the prevalence of these in the wild (error message is reusing the ESO one).

RyanCavanaugh · 2025-03-19T20:29:49Z

typescript-bot · 2025-03-19T20:29:54Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started	👀 Results

typescript-bot · 2025-03-19T23:11:41Z

@RyanCavanaugh Here are the results of running the top 800 repos with tsc comparing main and refs/pull/61450/merge:

Something interesting changed - please have a look.

Details

TypeStrong/typedoc

1 of 4 projects failed to build with the old tsc and were ignored

src/test/converter/tsconfig.json

error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.

RyanCavanaugh · 2025-03-21T18:48:43Z

@typescript-bot test top800
@typescript-bot run dt

typescript-bot · 2025-03-21T18:48:48Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top800`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results

typescript-bot · 2025-03-21T19:11:10Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-03-21T21:25:40Z

@RyanCavanaugh Here are the results of running the top 800 repos with tsc comparing main and refs/pull/61450/merge:

Something interesting changed - please have a look.

Details

blitz-js/blitz

25 of 27 projects failed to build with the old tsc and were ignored

packages/generator/tsconfig.json

error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.
- packages/generator/src/utils/log.ts#L10

TypeStrong/typedoc

1 of 4 projects failed to build with the old tsc and were ignored

src/test/converter/tsconfig.json

error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.

visgl/react-map-gl

11 of 40 projects failed to build with the old tsc and were ignored

modules/main/tsconfig.json

error TS1294: This syntax is not allowed when 'erasableSyntaxOnly' is enabled.
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L93 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L124 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L354 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L599 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L895 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L1463 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L1870 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2211 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2540 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2897 in modules/react-mapbox/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L93 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L124 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L354 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L599 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L895 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L1463 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L1870 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2211 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2540 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2897 in modules/react-maplibre/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L93 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L124 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L354 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L599 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L895 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L1463 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L1870 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2211 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2540 in modules/main/tsconfig.json
- file:///mnt/ts_downloads/_/m/react-map-gl/node_modules/gl-matrix/index.d.ts#L2897 in modules/main/tsconfig.json

RyanCavanaugh · 2025-03-21T21:54:52Z

gl-matrix builds index.d.ts from JS source (with --module amd --outFile!), but then patches out declare module "sub" { with declare module sub { with a custom build script

RyanCavanaugh added 2 commits March 19, 2025 13:28

Check for flag

6e72921

Add baselines

5bd5ec0

typescript-bot assigned RyanCavanaugh Mar 19, 2025

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Mar 19, 2025

RyanCavanaugh changed the title ~~Ban non-ambient modules written with module keyword~~ Ban non-ambient namespaces written with module keyword Mar 21, 2025

RyanCavanaugh added 2 commits March 21, 2025 11:47

Ban including ambient context

6050d59

Baselines

8d8b092

RyanCavanaugh mentioned this pull request Mar 21, 2025

6.0 Deprecation Candidates #54500

Open

robpalme mentioned this pull request Mar 22, 2025

Fix generated namespace types in index.d.ts toji/gl-matrix#487

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ban non-ambient namespaces written with `module` keyword #61450

Ban non-ambient namespaces written with `module` keyword #61450

RyanCavanaugh commented Mar 19, 2025

RyanCavanaugh commented Mar 19, 2025

typescript-bot commented Mar 19, 2025 •

edited

Loading

typescript-bot commented Mar 19, 2025

TypeStrong/typedoc

src/test/converter/tsconfig.json

RyanCavanaugh commented Mar 21, 2025

typescript-bot commented Mar 21, 2025 •

edited

Loading

typescript-bot commented Mar 21, 2025

typescript-bot commented Mar 21, 2025

blitz-js/blitz

packages/generator/tsconfig.json

TypeStrong/typedoc

src/test/converter/tsconfig.json

visgl/react-map-gl

modules/main/tsconfig.json

RyanCavanaugh commented Mar 21, 2025 •

edited

Loading

Ban non-ambient namespaces written with module keyword #61450

Are you sure you want to change the base?

Ban non-ambient namespaces written with module keyword #61450

Conversation

RyanCavanaugh commented Mar 19, 2025

RyanCavanaugh commented Mar 19, 2025

typescript-bot commented Mar 19, 2025 • edited Loading

typescript-bot commented Mar 19, 2025

RyanCavanaugh commented Mar 21, 2025

typescript-bot commented Mar 21, 2025 • edited Loading

typescript-bot commented Mar 21, 2025

typescript-bot commented Mar 21, 2025

RyanCavanaugh commented Mar 21, 2025 • edited Loading

Ban non-ambient namespaces written with `module` keyword #61450

Ban non-ambient namespaces written with `module` keyword #61450

typescript-bot commented Mar 19, 2025 •

edited

Loading

typescript-bot commented Mar 21, 2025 •

edited

Loading

RyanCavanaugh commented Mar 21, 2025 •

edited

Loading